Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add vs solution, it is safety because it only call nmake command, and it is friendly for edit, modify and debug code in Detours #138

Merged
merged 1 commit into from
Sep 7, 2020

Conversation

sonyps5201314
Copy link
Contributor

add vs solution, it is safety because it only call nmake command, and it is friendly for edit, modify and debug code in Detours

… it is friendly for edit, modify and debug code in Detours
@sonyps5201314
Copy link
Contributor Author

image
And it is very convenient, because you can open every thing in project by visual studio.

@bgianfo
Copy link
Contributor

bgianfo commented Sep 7, 2020

Thanks for the contribution!

I think this can go away when CMake support is finally merged with #48, as VS now supports CMake projects natively.
Until then, seems like a reasonable thing.
Thanks!

@bgianfo bgianfo merged commit 73e9a0a into microsoft:master Sep 7, 2020
@sonyps5201314
Copy link
Contributor Author

CMake is avant-garde, but at the same time it also has a learning cost. It has a bunch of documents, and not every developer can edit it, so if the user needs to add a sample or compile parameters, participants may need to spend a lot of time to learn it, and it is not Microsoft's own product, so if you use it in such an important level of product, you are also doing free promotion for it, and Detours' nmake compilation script has been working stably for so many years, easy to understand, and compatible with basically all VS versions, so I don't think it is very urgent to migrate to CMake.

@sylveon
Copy link
Contributor

sylveon commented Sep 7, 2020

I'd argue that Makefiles have a bigger learning cost :)

Existing MS projects like wil already use cmake, so it's not like MS isn't already "doing promotion"

@sonyps5201314
Copy link
Contributor Author

The makefile of vc is like the BAT batch file of the Windows system. It is only by modifying various environment variables to set the compilation parameters to finally call the compiler component of vc, so it is very easy to understand. And in this project, you only need to slightly modify and adjust the compilation parameters, or add a sample, which can be drawn from the gourd.

@sonyps5201314 sonyps5201314 deleted the add_vs_solution branch November 20, 2021 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants