fix: bug 2404 action scorer not showing memory values (#1402)

microsoft · Dec 5, 2019 · 2d67253 · 2d67253
1 parent 022ecf8
commit 2d67253
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 0 deletions.
diff --git a/src/components/ActionRenderers.tsx b/src/components/ActionRenderers.tsx
@@ -31,6 +31,7 @@ export function actionTypeRenderer(action: CLM.ActionBase | undefined): JSX.Elem
 export function actionListViewRenderer(
     action: CLM.ActionBase,
     entities: CLM.EntityBase[],
+    memories: CLM.Memory[],
     callbacks: CLM.Callback[],
     onClickViewCard: (action: CLM.ActionBase, cardViewerShowOriginal: boolean) => void
 ): React.ReactNode {
@@ -43,6 +44,7 @@ export function actionListViewRenderer(
             <ActionPayloadRenderers.TextPayloadRendererWithHighlights
                 textAction={textAction}
                 entities={entities}
+                memories={memories}
                 showMissingEntities={true}
             />)
     }
@@ -53,6 +55,7 @@ export function actionListViewRenderer(
             <ActionPayloadRenderers.ApiPayloadRendererWithHighlights
                 apiAction={apiAction}
                 entities={entities}
+                memories={memories}
                 callback={callback}
                 showMissingEntities={true}
             />)
@@ -64,6 +67,7 @@ export function actionListViewRenderer(
                 isValidationError={false}
                 cardAction={cardAction}
                 entities={entities}
+                memories={memories}
                 onClickViewCard={(_, showOriginal) => onClickViewCard(action, showOriginal)}
                 showMissingEntities={true}
             />)
@@ -74,6 +78,7 @@ export function actionListViewRenderer(
             <ActionPayloadRenderers.SessionPayloadRendererWithHighlights
                 sessionAction={sessionAction}
                 entities={entities}
+                memories={memories}
                 showMissingEntities={true}
             />)
     }

diff --git a/src/components/modals/ActionCreatorEditor/RepromptAction.tsx b/src/components/modals/ActionCreatorEditor/RepromptAction.tsx
@@ -53,6 +53,7 @@ class RepromptAction extends React.Component<Props, ComponentState> {
         const actionRender = (!this.props.selfprompt && this.props.action)
             ? actionListViewRenderer(this.props.action,
                 this.props.entities,
+                [],
                 this.props.botInfo.callbacks,
                 this.onClickViewCard)
             : undefined

diff --git a/src/components/modals/ActionScorer.tsx b/src/components/modals/ActionScorer.tsx
@@ -127,6 +127,7 @@ function getColumns(intl: InjectedIntl): IRenderableColumn[] {
             render: (action: CLM.ActionBase, component) => {
                 return actionListViewRenderer(action,
                     component.props.entities,
+                    component.props.memories,
                     component.props.botInfo.callbacks,
                     component.onClickViewCard)
             }

diff --git a/src/components/modals/ActionSelector.tsx b/src/components/modals/ActionSelector.tsx
@@ -60,6 +60,7 @@ function getColumns(intl: InjectedIntl): IRenderableColumn[] {
             render: (action: CLM.ActionBase, component) => {
                 return actionListViewRenderer(action,
                     component.props.entities,
+                    [],
                     component.props.botInfo.callbacks,
                     component.onClickViewCard)
             }