Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve build method API + small improvements #151

Merged
merged 1 commit into from
Oct 2, 2024
Merged

Improve build method API + small improvements #151

merged 1 commit into from
Oct 2, 2024

Conversation

dstepanov
Copy link
Collaborator

@dstepanov dstepanov commented Oct 1, 2024 •
edited
Loading

For the build method, returning a list of VariableDef.MethodParameter makes more sense

  • Small improvement in API after previous PR

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 1, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 70%)

See analysis details on SonarCloud

@dstepanov dstepanov merged commit ab3251b into 1.3.x Oct 2, 2024
6 of 7 checks passed
@dstepanov dstepanov deleted the impra branch October 2, 2024 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andriy-dmytruk andriy-dmytruk andriy-dmytruk approved these changes

@graemerocher graemerocher graemerocher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dstepanov @graemerocher @andriy-dmytruk