Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve errors and make super builders public #128

Merged
merged 1 commit into from
Aug 8, 2024
Merged

Improve errors and make super builders public #128

merged 1 commit into from
Aug 8, 2024

Conversation

graemerocher
Copy link
Contributor

@graemerocher graemerocher commented Aug 8, 2024 •
edited
Loading

  • Improves error messages
  • Makes generated super builders public

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Aug 8, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 70%)
1 New Bugs (required ≤ 0)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@graemerocher graemerocher merged commit 4cb7b27 into 1.2.x Aug 8, 2024
6 of 7 checks passed
@graemerocher graemerocher deleted the super-builder-issues branch August 8, 2024 18:36
@graemerocher graemerocher added the type: bug Something isn't working label Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andriy-dmytruk andriy-dmytruk andriy-dmytruk approved these changes

Assignees
No one assigned
Labels
type: bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@graemerocher @andriy-dmytruk