Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track processed classes. Fixes #122 #123

Merged
merged 1 commit into from
Jul 23, 2024
Merged

Track processed classes. Fixes #122 #123

merged 1 commit into from
Jul 23, 2024

Conversation

graemerocher
Copy link
Contributor

@graemerocher graemerocher commented Jul 22, 2024

Second round of compilation results in visiting the same class again. This prevents that.

@graemerocher
Copy link
Contributor Author

@dstepanov not sure if this is the correct fix and it will probably need to be applied to the SuperBuilderVisitor. Currently the same record is visited again in the second round of compilation.

@graemerocher graemerocher added the type: bug Something isn't working label Jul 22, 2024
Copy link

sonarcloud bot commented Jul 22, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 70%)

See analysis details on SonarCloud

@dstepanov
Copy link
Collaborator

I think this might be a Core problem

@graemerocher
Copy link
Contributor Author

Agreed, we probably need a fix for existing versions of Micronaut though

@graemerocher graemerocher merged commit 3a884e6 into 1.1.x Jul 23, 2024
6 of 7 checks passed
@graemerocher graemerocher deleted the issue122 branch July 23, 2024 11:41
graemerocher added a commit that referenced this pull request Jul 23, 2024
* Track processed classes.  (#123)

* address #122 in SuperBuilder
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants