Fix idle timeouts for websockets and streaming connections in 3.8.x #11004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this patch, the configured timeout would be applied for the read, write *and* combined streams. That means that if data was only sent in one direction on the connection, the timeout would trigger and the connection would close. This patch changes the timeout to only apply when no data is sent in either direction.
|
@melix so, what do we do about PRs like this, now that jcenter is broken? Can't build or test |
|
3.8.x ? wow. I guess it will require a fair amount of changes to fix the build :/ |
|
do we need the PR given the workaround is to set 0 to the timeout? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this patch, the configured timeout would be applied for the read, write and combined streams. That means that if data was only sent in one direction on the connection, the timeout would trigger and the connection would close.
This patch changes the timeout to only apply when no data is sent in either direction.