-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Hide app icon
option
#2462
base: master
Are you sure you want to change the base?
Add Hide app icon
option
#2462
Changes from 2 commits
81ead92
39c349b
6f4e97f
06d6fa6
2b6524a
2f64e62
27488e0
7ea14ed
cdefa13
3094aff
f7ebf66
ddacc9c
c1060b1
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
<?xml version="1.0" encoding="utf-8"?> | ||
<!-- | ||
~ SPDX-FileCopyrightText: 2019, The Android Open Source Project | ||
~ SPDX-FileCopyrightText: 2020, microG Project Team | ||
~ SPDX-License-Identifier: Apache-2.0 | ||
--> | ||
|
||
<vector xmlns:android="http://schemas.android.com/apk/res/android" | ||
android:width="24dp" | ||
android:height="24dp" | ||
android:viewportWidth="48" | ||
android:viewportHeight="48" | ||
android:tint="?attr/colorAccent"> | ||
<path | ||
android:fillColor="#FF000000" | ||
android:pathData="M39.6,43.85 L35.9,40.2Q33.4,42 30.4,43Q27.4,44 24,44Q19.75,44 16.1,42.475Q12.45,40.95 9.75,38.25Q7.05,35.55 5.525,31.9Q4,28.25 4,24Q4,20.6 5,17.6Q6,14.6 7.8,12.1L4.1,8.4Q3.65,7.95 3.675,7.35Q3.7,6.75 4.15,6.3Q4.6,5.85 5.225,5.85Q5.85,5.85 6.3,6.3L41.75,41.75Q42.2,42.2 42.2,42.8Q42.2,43.4 41.75,43.85Q41.3,44.3 40.675,44.3Q40.05,44.3 39.6,43.85ZM24,41Q26.75,41 29.2,40.225Q31.65,39.45 33.75,38.05L9.95,14.25Q8.55,16.35 7.775,18.8Q7,21.25 7,24Q7,31.25 11.875,36.125Q16.75,41 24,41ZM40.2,35.9 L38.05,33.75Q39.45,31.65 40.225,29.2Q41,26.75 41,24Q41,16.75 36.125,11.875Q31.25,7 24,7Q21.25,7 18.8,7.775Q16.35,8.55 14.25,9.95L12.1,7.8Q14.6,6 17.6,5Q20.6,4 24,4Q28.2,4 31.85,5.55Q35.5,7.1 38.2,9.8Q40.9,12.5 42.45,16.15Q44,19.8 44,24Q44,27.4 43,30.4Q42,33.4 40.2,35.9ZM26.15,21.85Q26.15,21.85 26.15,21.85Q26.15,21.85 26.15,21.85Q26.15,21.85 26.15,21.85Q26.15,21.85 26.15,21.85Q26.15,21.85 26.15,21.85Q26.15,21.85 26.15,21.85ZM21.85,26.15Q21.85,26.15 21.85,26.15Q21.85,26.15 21.85,26.15Q21.85,26.15 21.85,26.15Q21.85,26.15 21.85,26.15Q21.85,26.15 21.85,26.15Q21.85,26.15 21.85,26.15Z"/> | ||
</vector> |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -58,6 +58,7 @@ | |
import org.microg.gms.people.PeopleManager; | ||
import org.microg.gms.profile.Build; | ||
import org.microg.gms.profile.ProfileManager; | ||
import org.microg.gms.ui.UtilsKt; | ||
|
||
import java.io.IOException; | ||
import java.security.MessageDigest; | ||
|
@@ -75,6 +76,7 @@ | |
import static android.view.View.VISIBLE; | ||
import static android.view.inputmethod.InputMethodManager.SHOW_IMPLICIT; | ||
import static org.microg.gms.auth.AuthPrefs.isAuthVisible; | ||
import static org.microg.gms.checkin.CheckinPreferences.hideAppIcon; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. You add new imports without any need. Please remove them again There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Even though this PR made changes to play-services-core/src/main/kotlin/org/microg/gms/checkin/CheckinPreferences.kt and play-services-base/core/src/main/kotlin/org/microg/gms/ui/Utils.kt? |
||
import static org.microg.gms.common.Constants.GMS_PACKAGE_NAME; | ||
import static org.microg.gms.common.Constants.GMS_VERSION_CODE; | ||
|
||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -65,6 +65,11 @@ | |
android:title="@string/service_name_location"/> | ||
</PreferenceCategory> | ||
<PreferenceCategory android:layout="@layout/preference_category_no_label" android:key="prefcat_footer"> | ||
<SwitchPreferenceCompat | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I don't think this setting is so important that it deserves a prime location at the top level settings dialog. I suggest to create a new section for these kind of things, although I don't know how to name it or what else would belong there. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @mar-v-in
|
||
android:key="hideAppIcon" | ||
ILoveOpenSourceApplications marked this conversation as resolved.
Show resolved
Hide resolved
|
||
android:title="@string/pref_hide_app_icon" | ||
android:icon="@drawable/ic_hide_app_icon" | ||
android:defaultValue="false"/> | ||
<Preference | ||
android:icon="@drawable/ic_info_outline" | ||
android:key="pref_about" | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This does not belong into the Checkin settings contract. In fact it's not needed at all in
SettingsContract
orSettingsProvider
, see my other comment