Potential change of the event order to synchronize achievements befor…

…e the inventory (this has never been a problem before, but still)

CHANGELOG.md

@@ -1,2 +1,3 @@
 Update fork
 Add config flag SYNCHRONIZATION_DELAY_METHOD
+Potential change of the event order to synchronize achievements before the inventory (this has never been a problem before, but still)

src/main/java/de/michiruf/invsync/event/InvSyncEventsHandler.java

@@ -21,6 +21,14 @@ public class InvSyncEventsHandler {
      * @see net.minecraft.server.PlayerManager#createPlayer(GameProfile, PlayerPublicKey)
      */
     public static void registerEvents(Config config) {
+        // Synchronize achievements first for them not to get triggered by inventory updates
+        // Of cause this just registers the event, and does not specify the execution order explicitly
+        // but registering this first might already help
+        if (config.SYNC_ADVANCEMENTS) {
+            InvSyncEvents.FETCH_PLAYER_DATA.register((player, playerData) -> ((PlayerAdvancementTrackerAccessor) player.getAdvancementTracker()).writeAdvancementData(playerData.advancements));
+            InvSyncEvents.SAVE_PLAYER_DATA.register((player, playerData) -> playerData.advancements = ((PlayerAdvancementTrackerAccessor) player.getAdvancementTracker()).readAdvancementData());
+        }
+
         if (config.SYNC_INVENTORY) {
             InvSyncEvents.FETCH_PLAYER_DATA.register((player, playerData) -> {
                 player.getInventory().readNbt(playerData.inventory);
@@ -85,10 +93,5 @@ public static void registerEvents(Config config) {
                 playerData.effects = effects;
             });
         }
-
-        if (config.SYNC_ADVANCEMENTS) {
-            InvSyncEvents.FETCH_PLAYER_DATA.register((player, playerData) -> ((PlayerAdvancementTrackerAccessor) player.getAdvancementTracker()).writeAdvancementData(playerData.advancements));
-            InvSyncEvents.SAVE_PLAYER_DATA.register((player, playerData) -> playerData.advancements = ((PlayerAdvancementTrackerAccessor) player.getAdvancementTracker()).readAdvancementData());
-        }
     }
 }