Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Add ESLint and Prettier configs #179

Merged
merged 1 commit into from
Jun 3, 2020
Merged

chore: Add ESLint and Prettier configs #179

merged 1 commit into from
Jun 3, 2020

Conversation

danilofuchs
Copy link
Contributor

Related to #176

  • Removes JSHint in favour of ESLint
  • Enforces formatting rules through Prettier (integrated with ESLint)
  • Switches from npm to yarn
  • Format all current code with prettier
  • Fix linting errors

@danilofuchs danilofuchs mentioned this pull request May 28, 2020
Open
@michaelwittig
Copy link
Owner

@danilofuchs could you merge the latest updates to master (dropping node 8) to make the travis check work here?

@danilofuchs
Copy link
Contributor Author

@danilofuchs could you merge the latest updates to master (dropping node 8) to make the travis check work here?

I rebased my branch!

@michaelwittig michaelwittig merged commit 46d2a05 into michaelwittig:master Jun 3, 2020
@danilofuchs danilofuchs deleted the chore/eslint-and-prettier branch July 8, 2020 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danilofuchs @michaelwittig