-
Notifications
You must be signed in to change notification settings - Fork 255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove transaction module #442
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #442 +/- ##
==========================================
+ Coverage 89.77% 89.89% +0.12%
==========================================
Files 28 27 -1
Lines 2210 2118 -92
==========================================
- Hits 1984 1904 -80
+ Misses 226 214 -12 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Perhaps we should add a migration guide to the documentation? |
@kevinheavey Actually. I think it'd be better to emit a depreciation warning to notify users to use the solder's transaction rather than outright deletion. |
The transaaction module is broken (see #268) and
solders.transaction
works so I guess we should just use that?This also entails changing the
send_transaction
methods such that it is the caller's job to fetch a recent blockhash and sign the transaction