Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend SolanaExceptionBase with Original Exception Field #386

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pohape
Copy link

@pohape pohape commented Jan 10, 2024

No description provided.

Copy link

codecov bot commented Jan 21, 2024

Codecov Report

Merging #386 (e1f1194) into master (892d444) will increase coverage by 0.00%.
Report is 7 commits behind head on master.
The diff coverage is 66.66%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #386   +/-   ##
=======================================
  Coverage   89.99%   90.00%           
=======================================
  Files          28       28           
  Lines        2228     2230    +2     
=======================================
+ Hits         2005     2007    +2     
  Misses        223      223           

super().__init__()
self.error_msg = self._build_error_message(exc, func, *args, **kwargs)
self.original_exception = exc
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need to set this since _build_error_message is a static method

@@ -7,8 +7,10 @@ class SolanaExceptionBase(Exception):

def __init__(self, exc: Exception, func: Callable[[Any], Any], *args: Any, **kwargs: Any) -> None:
"""Init."""
def __init__(self, exc: Exception, func: Callable[[Any], Any], *args: Any, **kwargs: Any) -> None:
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
def __init__(self, exc: Exception, func: Callable[[Any], Any], *args: Any, **kwargs: Any) -> None:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants