This repository has been archived by the owner on Sep 15, 2021. It is now read-only.
Update to Eclipse RDF4J Sesame #23
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mostly namespaces changes as per directions on http://docs.rdf4j.org/migration/. Other changes are mostly URI-IRI and Graph-Model related (deprecations). Two tests still fail. Also note, version number updated because it was strange to see Pinto depend on a version that does not exist on Github (4.0.2). It was also hard to make a decision as to how to name the dependency. Chose to keep 'sesame' and where needed wrote 'sesameRdf4J' to clarify.
|
This is a breaking API change so the version should probably reflect that (4.1.0?). Pinto for example will need to be updated at the same time. I will send a separate pull request for that if this is good to go. |
There was a missing import, which also was for a deprecated method. There was access from a test class to a protected method -- there is no need for this as RDF4J specifically mentions use of ValueFactory. Note: Some inadvertent import organizations are in this baggage.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly namespaces changes as per directions on
http://docs.rdf4j.org/migration/. Other changes are mostly URI-IRI and
Graph-Model related (deprecations).
Two tests still fail. Also note, version number updated because it was
strange to see Pinto depend on a version that does not exist on Github
(4.0.2).
It was also hard to make a decision as to how to name the dependency.
Chose to keep 'sesame' and where needed wrote 'sesameRdf4J' to clarify.