-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add vector list datatype & add configurable SPACE_DIRECTIONS_TYPE
option
#157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Utilize np.asarray in relative formatters to ensure array is a numpy array.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
int vector list
anddouble vector list
datatypes that are lists of Numpy arrays orNone
.int matrix
anddouble matrix
counterparts except they are not 2D Numpy matrices.nrrd.SPACE_DIRECTIONS_TYPE
to enable switching the datatype for thespace directions
field.double matrix
ordouble vector list
. The current default isdouble matrix
for backwards compatibility but will be switched todouble vector list
in the next major release.double vector list
is superior overdouble matrix
because it doesn't have the confusing row-of-NaN's representation and it doesn't imply an affine transform by being a matrix.parse_optional_matrix
&format_optional_matrix
in addition to new vector list parsing/formatting functionsFixes #148
Revises #149