Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrected a couple of errors #3

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

jlhonora
Copy link

Hi,

When using the example code I discovered two details that I've corrected:

  1. The point sorting was being done in the incorrect order. (Y must be sorted after X).
  2. The last element of the hullPoints array should be removed in order to plot a correct convex hull.

I also added a simple .html example to play with, it shows two polylines, one with the old example and one with the new one.

Cheers!
Jose

@mgomes
Copy link
Owner

mgomes commented Jun 11, 2013

Thanks for the changes, Jose! I will take this opportunity to clean up the docs as well.

I have a question though, why did you rename the variable top to ttop in the js?

@jlhonora
Copy link
Author

Hi Mauricio, thanks for the quick follow up. It was highlighted as a special keyword in vim. Since I'm no expert in JavaScript I thought that maybe that could rise some kind of error, but the name 'top' should work perfectly.

Thanks for the library, it was very useful!!
Jose

Sent from a mobile device

On Jun 11, 2013, at 7:09 PM, Mauricio Gomes [email protected] wrote:

Thanks for the changes, Jose! I will take this opportunity to clean up the docs as well.

I have a question though, why did you rename the variable top to ttop in the js?


Reply to this email directly or view it on GitHub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants