Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed the mirroring bug that occurs when using a custom control naming pattern or when side names 'L' and 'R' are changed. #285

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Fixed the mirroring bug that occurs when using a custom control naming pattern or when side names 'L' and 'R' are changed. #285

wants to merge 4 commits into from

Commits on Sep 23, 2023

  1. Added a function to get a guide data from a rig node

    @joji2468ng
    joji2468ng committed Sep 23, 2023
    Configuration menu
    Copy the full SHA
    c758add View commit details
    Browse the repository at this point in the history

  2. deleted unnecessary code

    @joji2468ng
    joji2468ng committed Sep 23, 2023
    Configuration menu
    Copy the full SHA
    370991d View commit details
    Browse the repository at this point in the history

  3. Swap the side label of a given control name, based on the rig's namin… 

    …g convention

It fixes the mirroring issue with custom naming conventions.

The function uses the guide data's naming patterns to identify the current side label
(e.g., "L", "R", etc.) in the provided name, and swaps it to the opposite side.

If the side is "center" or not recognized, the original name is returned.
    @joji2468ng
    joji2468ng committed Sep 23, 2023
    Configuration menu
    Copy the full SHA
    543252b View commit details
    Browse the repository at this point in the history

Commits on Sep 24, 2023

  1. Mirror process is a bit faster with avoiding to load guide data every… 

    … time
    @joji2468ng
    joji2468ng committed Sep 24, 2023
    Configuration menu
    Copy the full SHA
    010780e View commit details
    Browse the repository at this point in the history