Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support empty collections in _embedded section #80

Merged
merged 38 commits into from
Aug 1, 2023
Merged

Support empty collections in _embedded section #80

merged 38 commits into from
Aug 1, 2023

Commits on Jun 8, 2023

  1. Update HalResourceTest.php 

    Signed-off-by: Nathanael Esayeas <[email protected]>
    @ghostwriter
    ghostwriter committed Jun 8, 2023
    Configuration menu
    Copy the full SHA
    1e98f8d View commit details
    Browse the repository at this point in the history

  2. Create empty-contacts-collection.json 

    Signed-off-by: Nathanael Esayeas <[email protected]>
    @ghostwriter
    ghostwriter committed Jun 8, 2023
    Configuration menu
    Copy the full SHA
    ec0ef25 View commit details
    Browse the repository at this point in the history

  3. Create non-empty-contacts-collection.json 

    Signed-off-by: Nathanael Esayeas <[email protected]>
    @ghostwriter
    ghostwriter committed Jun 8, 2023
    Configuration menu
    Copy the full SHA
    a664f13 View commit details
    Browse the repository at this point in the history

  4. Update HalResource.php 

    Signed-off-by: Nathanael Esayeas <[email protected]>
    @ghostwriter
    ghostwriter committed Jun 8, 2023
    Configuration menu
    Copy the full SHA
    a77e5bc View commit details
    Browse the repository at this point in the history

  5. Update HalResourceTest.php 

    Signed-off-by: Nathanael Esayeas <[email protected]>
    @ghostwriter
    ghostwriter committed Jun 8, 2023
    Configuration menu
    Copy the full SHA
    39b7a35 View commit details
    Browse the repository at this point in the history

Commits on Jun 28, 2023

  1. Fix Psalm issue 

    Signed-off-by: Nathanael Esayeas <[email protected]>
    @ghostwriter
    ghostwriter committed Jun 28, 2023
    Configuration menu
    Copy the full SHA
    aa29f66 View commit details
    Browse the repository at this point in the history

  2. Guard against invalid json decoding 

    Signed-off-by: Nathanael Esayeas <[email protected]>
    @ghostwriter
    ghostwriter committed Jun 28, 2023
    Configuration menu
    Copy the full SHA
    588faf5 View commit details
    Browse the repository at this point in the history

  3. Fix Phpcs issue 

    Signed-off-by: Nathanael Esayeas <[email protected]>
    @ghostwriter
    ghostwriter committed Jun 28, 2023
    Configuration menu
    Copy the full SHA
    3b01dbc View commit details
    Browse the repository at this point in the history

Commits on Jul 14, 2023

  1. Update ConfigProvider.php 

    Signed-off-by: Nathanael Esayeas <[email protected]>
    @ghostwriter
    ghostwriter committed Jul 14, 2023
    Configuration menu
    Copy the full SHA
    67fa194 View commit details
    Browse the repository at this point in the history

  2. Fix CS issue 

    Signed-off-by: Nathanael Esayeas <[email protected]>
    @ghostwriter
    ghostwriter committed Jul 14, 2023
    Configuration menu
    Copy the full SHA
    96327a4 View commit details
    Browse the repository at this point in the history

  3. Update HalResource.php 

    Signed-off-by: Nathanael Esayeas <[email protected]>
    @ghostwriter
    ghostwriter committed Jul 14, 2023
    Configuration menu
    Copy the full SHA
    88d9f06 View commit details
    Browse the repository at this point in the history

Commits on Jul 15, 2023

  1. Update ResourceGenerator.php 

    Signed-off-by: Nathanael Esayeas <[email protected]>
    @ghostwriter
    ghostwriter committed Jul 15, 2023
    Configuration menu
    Copy the full SHA
    2538c2b View commit details
    Browse the repository at this point in the history

  2. Create null-contacts-collection.json 

    Signed-off-by: Nathanael Esayeas <[email protected]>
    @ghostwriter
    ghostwriter committed Jul 15, 2023
    Configuration menu
    Copy the full SHA
    78c2bf5 View commit details
    Browse the repository at this point in the history

  3. Update ResourceGeneratorTest.php 

    Signed-off-by: Nathanael Esayeas <[email protected]>
    @ghostwriter
    ghostwriter committed Jul 15, 2023
    Configuration menu
    Copy the full SHA
    f170e24 View commit details
    Browse the repository at this point in the history

  4. Update HalResourceTest.php 

    Signed-off-by: Nathanael Esayeas <[email protected]>
    @ghostwriter
    ghostwriter committed Jul 15, 2023
    Configuration menu
    Copy the full SHA
    b0f6d89 View commit details
    Browse the repository at this point in the history

  5. Update HalResource.php 

    Signed-off-by: Nathanael Esayeas <[email protected]>
    @ghostwriter
    ghostwriter committed Jul 15, 2023
    Configuration menu
    Copy the full SHA
    0baf7dc View commit details
    Browse the repository at this point in the history

  6. Suppress Psalm issue 

    Signed-off-by: Nathanael Esayeas <[email protected]>
    @ghostwriter
    ghostwriter committed Jul 15, 2023
    Configuration menu
    Copy the full SHA
    bad20ad View commit details
    Browse the repository at this point in the history

  7. Merge branch 'mezzio:2.7.x' into feature/support-empty-collections-in… 

    …-embedded-section
    @ghostwriter
    ghostwriter authored Jul 15, 2023
    Configuration menu
    Copy the full SHA
    d49e1b9 View commit details
    Browse the repository at this point in the history

Commits on Jul 18, 2023

  1. Remove doc comment 

    Signed-off-by: Nathanael Esayeas <[email protected]>
    @ghostwriter
    ghostwriter committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    11ffa3b View commit details
    Browse the repository at this point in the history

  2. Add documentation 

    Signed-off-by: Nathanael Esayeas <[email protected]>
    @ghostwriter
    ghostwriter committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    ca2b505 View commit details
    Browse the repository at this point in the history

  3. Update links-and-resources.md 

    Signed-off-by: Nathanael Esayeas <[email protected]>
    @ghostwriter
    ghostwriter committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    28b572f View commit details
    Browse the repository at this point in the history

  4. Fix unrelated cs issue 

    Signed-off-by: Nathanael Esayeas <[email protected]>
    @ghostwriter
    ghostwriter committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    e0ddb0e View commit details
    Browse the repository at this point in the history

  5. Specify configuration file path 

    Signed-off-by: Nathanael Esayeas <[email protected]>
    @ghostwriter
    ghostwriter committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    0c2aa96 View commit details
    Browse the repository at this point in the history

Commits on Jul 31, 2023

  1. Update src/ResourceGenerator.php 

    Commit suggestion: The above makes the order of operations more clear. Additionally, our CS has us put operators on the next line.

Co-authored-by: Matthew Weier O'Phinney <[email protected]>
Signed-off-by: Nathanael Esayeas <[email protected]>
    @ghostwriter @weierophinney
    ghostwriter and weierophinney authored Jul 31, 2023
    Configuration menu
    Copy the full SHA
    5a24772 View commit details
    Browse the repository at this point in the history

  2. Update test/HalResourceTest.php 

    Co-authored-by: Matthew Weier O'Phinney <[email protected]>
Signed-off-by: Nathanael Esayeas <[email protected]>
    @ghostwriter @weierophinney
    ghostwriter and weierophinney authored Jul 31, 2023
    Configuration menu
    Copy the full SHA
    e7e825d View commit details
    Browse the repository at this point in the history

  3. Update test/HalResourceTest.php 

    Co-authored-by: Matthew Weier O'Phinney <[email protected]>
Signed-off-by: Nathanael Esayeas <[email protected]>
    @ghostwriter @weierophinney
    ghostwriter and weierophinney authored Jul 31, 2023
    Configuration menu
    Copy the full SHA
    9330126 View commit details
    Browse the repository at this point in the history

  4. Update test/HalResourceTest.php 

    Co-authored-by: Matthew Weier O'Phinney <[email protected]>
Signed-off-by: Nathanael Esayeas <[email protected]>
    @ghostwriter @weierophinney
    ghostwriter and weierophinney authored Jul 31, 2023
    Configuration menu
    Copy the full SHA
    228c4e7 View commit details
    Browse the repository at this point in the history

  5. Update test/HalResourceTest.php 

    Commit suggestion: Since the default behavior remains unchanged, we should note in the test that the tested behavior is specifically for when the embed empty collections option is toggled on.

Co-authored-by: Matthew Weier O'Phinney <[email protected]>
Signed-off-by: Nathanael Esayeas <[email protected]>
    @ghostwriter @weierophinney
    ghostwriter and weierophinney authored Jul 31, 2023
    Configuration menu
    Copy the full SHA
    27bae41 View commit details
    Browse the repository at this point in the history

  6. Update links-and-resources.md 

    Add a note here that this feature is available since version 2.7.0.

Signed-off-by: Nathanael Esayeas <[email protected]>
    @ghostwriter
    ghostwriter committed Jul 31, 2023
    Configuration menu
    Copy the full SHA
    ba594cc View commit details
    Browse the repository at this point in the history

  7. Update HalResource.php 

    Use constructor property promotion here

Signed-off-by: Nathanael Esayeas <[email protected]>
    @ghostwriter
    ghostwriter committed Jul 31, 2023
    Configuration menu
    Copy the full SHA
    188caec View commit details
    Browse the repository at this point in the history

  8. Reinstate removed tests 

    Signed-off-by: Nathanael Esayeas <[email protected]>
    @ghostwriter
    ghostwriter committed Jul 31, 2023
    Configuration menu
    Copy the full SHA
    adb411d View commit details
    Browse the repository at this point in the history

  9. Add phpcs:ignore 

    Signed-off-by: Nathanael Esayeas <[email protected]>
    @ghostwriter
    ghostwriter committed Jul 31, 2023
    Configuration menu
    Copy the full SHA
    6be416c View commit details
    Browse the repository at this point in the history

  10. Fix pslam issue 

    Signed-off-by: Nathanael Esayeas <[email protected]>
    @ghostwriter
    ghostwriter committed Jul 31, 2023
    Configuration menu
    Copy the full SHA
    a7b9f9e View commit details
    Browse the repository at this point in the history

Commits on Aug 1, 2023

  1. Update docs/book/v2/links-and-resources.md 

    commit suggestion

Co-authored-by: Frank Brückner <[email protected]>
Signed-off-by: Nathanael Esayeas <[email protected]>
    @ghostwriter @froschdesign
    ghostwriter and froschdesign authored Aug 1, 2023
    Configuration menu
    Copy the full SHA
    b65df9a View commit details
    Browse the repository at this point in the history

  2. Update docs/book/v2/links-and-resources.md 

    commit suggestion

Co-authored-by: Frank Brückner <[email protected]>
Signed-off-by: Nathanael Esayeas <[email protected]>
    @ghostwriter @froschdesign
    ghostwriter and froschdesign authored Aug 1, 2023
    Configuration menu
    Copy the full SHA
    a2f1bbf View commit details
    Browse the repository at this point in the history

  3. Update docs/book/v2/links-and-resources.md 

    commit suggestion

Co-authored-by: Frank Brückner <[email protected]>
Signed-off-by: Nathanael Esayeas <[email protected]>
    @ghostwriter @froschdesign
    ghostwriter and froschdesign authored Aug 1, 2023
    Configuration menu
    Copy the full SHA
    c155d75 View commit details
    Browse the repository at this point in the history

  4. Update links-and-resources.md 

    Fix Documentation Linting issues

Signed-off-by: Nathanael Esayeas <[email protected]>
    @ghostwriter
    ghostwriter committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    e82ee83 View commit details
    Browse the repository at this point in the history

  5. Update test/HalResourceTest.php 

    Signed-off-by: Matthew Weier O'Phinney <[email protected]>
    @weierophinney
    weierophinney authored Aug 1, 2023
    Configuration menu
    Copy the full SHA
    b432dfd View commit details
    Browse the repository at this point in the history