Optionally pass the Beautiful Soup object to constructors #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @biolds, Thanks for the PR, nice feature. But needs some changes:
|
|
Outch, I did not notice I broke so much stuff :) |
meyt
reviewed
Sep 26, 2024
linkpreview/linkpreview.py
Outdated
| @@ -14,13 +17,21 @@ | |||
|
|
|||
|
|
|||
| class LinkPreview: | |||
| def __init__(self, link: Link, parser: str = PARSER): | |||
| def __init__(self, link: Link, parser: Union[str, None] = PARSER, soup: Union[BeautifulSoup, None] = None): | |||
| if parser and soup: | |||
There was a problem hiding this comment.
@biolds No need to check the arguments twice, just in PreviewBase is enough.
meyt
reviewed
Sep 26, 2024
linkpreview/preview/base.py
Outdated
| raise Exception( | ||
| 'Only one of `parser` or `soup` argument must be provided to PreviewBase') | ||
|
|
||
| if not parser and not soup: |
There was a problem hiding this comment.
@biolds This kind of validation is not necessary. bs4 is fine without passing parser, and also the developer will receive proper exception if not specifing the soup.
meyt
reviewed
Sep 27, 2024
| for key in tout.keys(): | ||
| assert getattr(preview, key) == tout[key] | ||
|
|
||
|
|
||
| def test_bs4_object(): |
There was a problem hiding this comment.
@biolds Please don't touch other test cases, keep this and add another case for when both parser and soup are set.
|
It's updated. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
Thanks for this nice library! I would like to integrate it into the Sosse project, a search engine and crawler I'm writing. In this context, I'm extracting the preview while I already have a Soup object with the web page content. So, here is a small patch that permits passing the Soup object without parsing the page again.