Skip to content

Commit

Permalink
Recent change made in PR #330
Browse files Browse the repository at this point in the history
We’re rendering markers first so that they’re behind our plots.
Otherwise, they don’t look too good.
  • Loading branch information
almossawi committed Jan 22, 2015
1 parent a7f14aa commit f069405
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/js/common/data_graphic.js
Original file line number Diff line number Diff line change
Expand Up @@ -200,7 +200,7 @@ MG.data_graphic = function() {
}
else {
args = merge_with_defaults(args, defaults.all);
charts.line(args).mainPlot().markers().rollover().windowListeners();
charts.line(args).markers().mainPlot().rollover().windowListeners();
}

return args.data;
Expand Down

2 comments on commit f069405

@mikaelbr
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will cause a bug when updating a graph, as the markers will switch from being behind plots to in front of. Also, it would seem to me that it's "more correct" having the metadata on the top. If it looks bad, CSS should be used to make it transparent or change its style?

@almossawi
Copy link
Contributor Author

@almossawi almossawi commented on f069405 Feb 6, 2015 via email

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign in to comment.