Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: use hyper-rustls #489

Merged
merged 2 commits into from
Jun 18, 2024
Merged

refactor: use hyper-rustls #489

merged 2 commits into from
Jun 18, 2024

Conversation

tessus
Copy link
Contributor

@tessus tessus commented Jun 1, 2024

From #420 (comment):

After doing some reading, it seems like we should probably just switch to using rustls entirely.

I don't think the initial implementor choose to use hyper-tls specifically for the OS-backed/dynamically-linked aspect, and I don't personally care about esoteric SSL/TLS setups or FIPS compliance or any of that... so I'd rather go with a single solution than force users to have to spend time understanding which one they ought to choose.

This PR switches to hyper-rustls.

@tessus
Copy link
Contributor Author

tessus commented Jun 17, 2024

@tobz what do you think?

tobz
tobz requested changes Jun 18, 2024
View reviewed changes
Copy link
Member

@tobz tobz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for the delay in reviewing.

Just one small change that needs to be made and then I think it should be good to go.

metrics-exporter-prometheus/src/exporter/push_gateway.rs Outdated Show resolved Hide resolved
@tessus tessus requested a review from tobz June 18, 2024 05:51
@tobz tobz merged commit 654c3a1 into metrics-rs:main Jun 18, 2024
12 checks passed
@faultymajority
Copy link

Awesome - this also unlocks compiling static binaries on Linux for easy distribution.
Is a corresponding release of metrics-exporter-prometheus planned soon?

@tobz
Copy link
Member

tobz commented Jun 23, 2024

I'm going to try to get this released today.

@tobz tobz added C-exporter Component: exporters such as Prometheus, TCP, etc. E-simple Effort: simple. T-refactor Type: refactor. S-awaiting-release Status: awaiting a release to be considered fixed/implemented. labels Jun 24, 2024
@tobz
Copy link
Member

tobz commented Jun 24, 2024

Released in [email protected].

Thanks again for your contribution!

@tobz tobz removed the S-awaiting-release Status: awaiting a release to be considered fixed/implemented. label Jun 24, 2024
@tessus
Copy link
Contributor Author

tessus commented Jun 24, 2024

Thank you for merging and for the release! Have a great evening.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobz tobz tobz approved these changes

Assignees
No one assigned
Labels
C-exporter Component: exporters such as Prometheus, TCP, etc. E-simple Effort: simple. T-refactor Type: refactor.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tessus @faultymajority @tobz