Relax bounds on some metrics_util::registry::Registry methods
#484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `Registry` struct definition requires `K: Hashable`, which is superfluous since it's already required in the impl block. Moreover, some methods don't require the full `K: Clone + Eq + Hashable` bounds. Some methods only require `K: Eq + Hashable`, others only require `K: Hashable`, while others don't require any bounds at all on `K`. This commit splits the single impl block into three impl blocks, so users that have keys that don't satisfy all bounds can still make use of some methods.
david-perez
commented
May 10, 2024
| @@ -47,7 +47,6 @@ type RegistryHashMap<K, V> = HashMap<K, V, BuildHasherDefault<RegistryHasher>>; | |||
| /// `Registry` is optimized for reads. | |||
| pub struct Registry<K, S> | |||
| where | |||
| K: Hashable, | |||
| S: Storage<K>, | |||
| { | |||
| counters: Vec<RwLock<RegistryHashMap<K, S::Counter>>>, | |||
There was a problem hiding this comment.
Out of curiosity, why are we explicitly depending on a hashbrown::HashMap for this type? Isn't the standard library's identical?
There was a problem hiding this comment.
std::collections::HashMap<K, V> is based on hashbrown now, yes, but we use the raw entry API, which is still not yet stabilized in the standard library.
tobz
added
C-util
|
Released in Thanks again for your contribution. 🙏🏻 |
tobz
removed
the
S-awaiting-release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was thinking through #481 when I noticed this possible bounds relaxation.
The
Registrystruct definition requiresK: Hashable, which issuperfluous since it's already required in the impl block.
Moreover, some methods don't require the full
K: Clone + Eq + Hashablebounds. Some methods only require
K: Eq + Hashable, others onlyrequire
K: Hashable, while others don't require any bounds at all onK.This commit splits the single impl block into three impl blocks, so
users that have keys that don't satisfy all bounds can still make use of
some methods.