Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically, it's not that hard to pass couple options to enable SSL (and HTTP/2 as well).
However, after some initial research, I have some questions to elaborate on:
:key-managers
and:trust-managers
options needed as well, or it would be okay for users to pass it explicitly toSSLContext
?pem-string->ssl-context
can be implemented usingbouncycastle/bcpkix-jdk15on
, but again: one more dependency. Plus, some additional responsibility is required for implementing it right way (this repo can be useful).