Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quick poke on schematized def #776

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Quick poke on schematized def #776

wants to merge 1 commit into from

Conversation

ikitommi
Copy link
Member

@ikitommi ikitommi commented Oct 28, 2022 •
edited
Loading

... should this fail always or just under instrumentation? Plumatic fails always.

TODO:

  • support :malli/always meta to fail early
  • collect schematized defs also to a registry (new registry or the current with a hint, it's not fn schema?)
  • tests

Screenshot 2022-10-28 at 16 55 31

@escherize
Copy link
Contributor

mx/defn only fails from isntrumentation. I think using :malli/always is the way to go here.

@ikitommi
Copy link
Member Author

ikitommi commented Feb 4, 2023

:malli/always is a good idea!

@ikitommi
Copy link
Member Author

there is no way to collect non-function schemas atm. need to add support for it before this can be merged.

@ikitommi ikitommi mentioned this pull request Jul 4, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
Metosin Open Source Backlog
Status: 🇰‍🇼 Waiting
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ikitommi @escherize