Avoid cancellation of other architecture tests if one fails #345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why? the point of cancelling is to not waste CI time doing the same thing twice since the CI will have to re-run after the one architecture is fixed. |
|
I think it's useful to see what broke and what didn't. Anyway, there is a codecov issue |
|
It can be useful, but it also hogs resources in a single PR. As far as I understand, github only allows for a limited number of simultaneous jobs across a given organization, so every job running on code that we know is broken might prevent CI from running in a separate PR on a separate repo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevents all architecture tests from being cancelled if one fails
📚 Documentation preview 📚: https://metatrain--345.org.readthedocs.build/en/345/