Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tutorial how to override arch params #32

Merged
merged 1 commit into from
Jan 20, 2024
Merged

Conversation

PicoCentauri
Copy link
Contributor

@PicoCentauri PicoCentauri commented Jan 18, 2024

Fixes #23


📚 Documentation preview 📚: https://metatensor-models--32.org.readthedocs.build/en/32/

@PicoCentauri PicoCentauri force-pushed the arch_override_docs branch 2 times, most recently from 81d2ce8 to fdb5de8 Compare January 18, 2024 13:40
@@ -1,5 +1,6 @@
defaults:
- architecture: soap_bpnn # architecture used to train the model
- _self_

# Section defining the parameters for structure and target data
dataset:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks quite a bit different from the previous discussion, is this the old version of the parameters?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes it still builds on the current main branch, where the new option was not in until 5 minutes ago.

I will rebase and update the config.

syntax are available at https://hydra.cc/docs/advanced/override_grammar/basic/.

.. note::
`metatensor-models` always writes the fully expanded ``options.yaml`` for your
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should tell where the fully expanded file can be found

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, good point.

Copy link
Collaborator

@frostedoyster frostedoyster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, I don't think we should mention the option of having the defaults override our custom config. Let's make it simple for the user: just put _self_ at the very end. I like the idea of having links to hydra for more advanced settings, but I just wouldn't mention the alternatives in our docs because they don't apply to our users

Comment on lines 16 to 17
:ref:`available-architectures` section. For SOAP-BPNN models, the parameters are
detailed at :ref:`architecture-soap-bpnn`.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
:ref:`available-architectures` section. For SOAP-BPNN models, the parameters are
detailed at :ref:`architecture-soap-bpnn`.
:ref:`available-architectures` section. For example, the parameters of the SOAP-BPNN models are
detailed at :ref:`architecture-soap-bpnn`.

training:
num_epochs: 200

# Dataset config omitted for simplicity.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here we should have a very minimal dataset.

training_set: your_dataset.xyz


.. note::
`metatensor-models` always writes the fully expanded ``options.yaml`` for your
reference.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
reference.
reference and reproducibility purposes.

@PicoCentauri
Copy link
Contributor Author

I pushed an update to the tutorial. Let me know, if this is better.

@PicoCentauri PicoCentauri merged commit 9e894b3 into main Jan 20, 2024
7 checks passed
@PicoCentauri PicoCentauri deleted the arch_override_docs branch January 20, 2024 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add example how to override architecture's default parameters
3 participants