🌱 Adding ipxe builder to init container

[adilGhaffarDev]

What this PR does / why we need it:
Adding ipxe builder to ironic init container

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

[metal3-io-bot]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[mquhuy]

So this ipxe-builder will run as an init container for ironic? Why does it have its own overlays?

[Rozzii]

So this ipxe-builder will run as an init container for ironic? Why does it have its own overlays?

Yes it will run as init container, the idea is that it is not mandatory if user is fine with the default iPXE firmware then this init container is not needed.

[mquhuy]

I think the overlays names should be something like with-ipxe-builder, instead of ipxe-builder. That overlay should install ironic with ipxe-builder as an init container, not just the ipxe-builder itself.

I left an inline comment. Currently this overlay should give us tls on ipxe-builder, but not on ironic. Not sure if that's what we want?

[mquhuy]

So this ipxe-builder will run as an init container for ironic? Why does it have its own overlays?

Yes it will run as init container, the idea is that it is not mandatory if user is fine with the default iPXE firmware that this init container is not needed.

Thanks for the explanation. I was confused by the overlays names.

[dtantsur]

Note: everything happening here should be repeated in ironic-standalone-operator.

[Rozzii]

FYI: I have started reviewing this, looks good but I have not finished yet.

[mquhuy]

/lgtm

[tuminoid]

LGTM to me

[Rozzii]

/approve

[metal3-io-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Rozzii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [Rozzii]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment