Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Host live updates - proof of concept #1689

Closed
wants to merge 2 commits into from
Closed

✨ Host live updates - proof of concept #1689

wants to merge 2 commits into from

Conversation

dtantsur
Copy link
Member

No description provided.

@metal3-io-bot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@metal3-io-bot metal3-io-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 19, 2024
@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from dtantsur. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 19, 2024
@dtantsur dtantsur force-pushed the live-updates branch 2 times, most recently from f65005a to 0b15044 Compare April 23, 2024 12:50
@metal3-io-bot metal3-io-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 23, 2024
@dtantsur dtantsur mentioned this pull request Apr 24, 2024
Merged
@dtantsur dtantsur force-pushed the live-updates branch 3 times, most recently from 74cdf5d to cb2450e Compare April 25, 2024 14:51
@dtantsur
Copy link
Member Author

/test metal3-bmo-e2e-test-pull

1 similar comment
@dtantsur
Copy link
Member Author

/test metal3-bmo-e2e-test-pull

@dtantsur
Copy link
Member Author

/test metal3-bmo-e2e-test-pull

@metal3-io-bot metal3-io-bot added the needs-rebase Indicates that a PR cannot be merged because it has merge conflicts with HEAD. label Apr 30, 2024
@metal3-io-bot metal3-io-bot removed the needs-rebase Indicates that a PR cannot be merged because it has merge conflicts with HEAD. label May 2, 2024
@dtantsur
Copy link
Member Author

dtantsur commented May 2, 2024

/test metal3-bmo-e2e-test-pull

@dtantsur
Provisioner code for servicing
0219e0e 
Signed-off-by: Dmitry Tantsur <[email protected]>
@dtantsur dtantsur force-pushed the live-updates branch 2 times, most recently from 1ad33fc to f2c9350 Compare May 2, 2024 12:37
@dtantsur
Wire in servicing (updating provisioned hosts)
79c1b7c 
Servicing only runs when a host is powered off (either completely or
by rebooting it).

Signed-off-by: Dmitry Tantsur <[email protected]>
@dtantsur
Copy link
Member Author

dtantsur commented May 2, 2024

/test metal3-bmo-e2e-test-pull

@pszczerbik
Copy link

Hi @dtantsur. Great job on preparing this PoC. I noticed that your design proposal for Live updates (servicing) was approved last week. I'm also interested in adding support for servicing to Metal3. Are you currently working on finishing this PoC and getting it merged? I'd really appreciate if you could share any additional information.

@dtantsur
Copy link
Member Author

@pszczerbik hi, @rhjanders was going to look into it, but got stuck with some issues on the Ironic side.

The missing part in this PR is the new API from the design proposal.

@dtantsur
Copy link
Member Author

Note: requires gophercloud 2.1.0 that fixes the incorrect value of the ServiceFail constant.

@metal3-io-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues will close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@metal3-io-bot metal3-io-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 23, 2024
@iurygregory
Copy link
Member

We can probably close this one, right?

@metal3-io-bot metal3-io-bot added the needs-rebase Indicates that a PR cannot be merged because it has merge conflicts with HEAD. label Nov 10, 2024
@metal3-io-bot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@dtantsur dtantsur closed this Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. needs-rebase Indicates that a PR cannot be merged because it has merge conflicts with HEAD. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
Metal3 - Roadmap
Status: Done / Closed
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dtantsur @metal3-io-bot @pszczerbik @iurygregory