🌱 Improve deploy.sh to differentiate between build and run of kustomize #1622
Conversation
Signed-off-by: Chris Coates <[email protected]>
metal3-io-bot
added
the
needs-ok-to-test
|
Hi @CJCShadowsan. Thanks for your PR. I'm waiting for a metal3-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
metal3-io-bot
added
the
size/XS
|
/ok-to-test |
metal3-io-bot
added
ok-to-test
|
/test-centos-e2e-integration-main |
|
/cc @kashifest |
|
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with /lifecycle stale |
metal3-io-bot
added
the
lifecycle/stale
|
/remove-lifecycle stale |
|
/lgtm |
|
/cc @elfosardo |
|
/remove-lifecycle stale |
metal3-io-bot
removed
the
lifecycle/stale
| @@ -110,7 +110,8 @@ mkdir -p "${TEMP_BMO_OVERLAY}" | |||
| mkdir -p "${TEMP_IRONIC_OVERLAY}" | |||
|
|
|||
| KUSTOMIZE="${SCRIPTDIR}/tools/bin/kustomize" | |||
There was a problem hiding this comment.
maybe can be done in a follow up but if you invert the lines between KUSTOMIZE and KUSTOMIZE_BUILD you can reuse the latter to build the former
|
/approve |
|
/cc @zaneb |
|
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with /lifecycle stale |
metal3-io-bot
added
the
lifecycle/stale
|
/cc @kashifest @dtantsur |
|
/remove-lifecycle stale |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: elfosardo, kashifest The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
metal3-io-bot
added
the
approved
What this PR does / why we need it:
Currently deploy.sh tries to use ${SCRIPTDIR} in its KUSTOMIZE variable which breaks calling it via the Makefile to build kustomize in some cases (it certainly does on my system!). To fix, I added another variable, KUSTOMIZE_BUILD which points to exactly what the Makefile wants to see.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #