-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding contentEncoding
and contentMediaType
to 3.1
#126
Conversation
The CI fails to run
Consider switching to tsx |
@pjmolina , please review. |
contentEncoding
and contentMediaType
contentEncoding
and contentMediaType
to 3.1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your changes, makes sense to me @RobinTail.
Two comments/questions before merging:
Can we replace in full ts-node to use tsx? Just to avoid having 2 dependencies for the same task.
Can you move these tools from the dependencies to dev-dependencies block as they are not needed for distribution?
Sure, @pjmolina , I can improve it accordingly. |
All done, @pjmolina .
|
Thanks @RobinTail |
Adding two new fields to the SchemaObject of 3.1.
The
contentEncoding
is supposed to override theformat
(such asbinary
) for the case of file transfer.The
contentMediaType
is optional when defined as a key ofContentObject
but it's JSON Schema compliant.First appearance in 3.1.0 RC0:
https://github.com/OAI/OpenAPI-Specification/releases/tag/3.1.0-rc0
Documentation:
https://swagger.io/specification/?#considerations-for-file-uploads