Skip to content

Commit

Permalink
Merge branch 'develop'
Browse files Browse the repository at this point in the history
  • Loading branch information
jvendetti committed May 3, 2021
2 parents 43aaa75 + 15f3016 commit e1c6f6f
Show file tree
Hide file tree
Showing 4 changed files with 16 additions and 16 deletions.
4 changes: 2 additions & 2 deletions phs-gdc-dashboard/src/components/AppContent.js
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ export default function AppContent() {
<Grid item md={4}>
<Card className={classes.card}>
<Step1
title={"Select Index Variable"}
title={"Select Locations"}
setPhsVariableName={setPhsVariableName}
setPhsVariableValues={setPhsVariableValues}
showPhsVariableValuesError={showPhsVariableValuesError}
Expand All @@ -65,7 +65,7 @@ export default function AppContent() {
</Grid>
<Grid item md={4}>
<Card className={classes.card}>
<Step2 title={"Select DC Variables"}
<Step2 title={"Select Data Variables"}
setDcVariableNames={setDcVariableNames}
showDcVariableNamesError={showDcVariableNamesError}
validateStep2DcVariableNames={validateStep2DcVariableNames}
Expand Down
22 changes: 11 additions & 11 deletions phs-gdc-dashboard/src/components/content/Step1.js
Original file line number Diff line number Diff line change
Expand Up @@ -95,34 +95,34 @@ export default function Step1(props) {
>&nbsp;&nbsp;&nbsp;</IconButton>
}
/>
<p className={"stepSubHeader"}>Select the variable that will link your data to Data Commons</p>
<p className={"stepSubHeader"}>Select locations we can use to look up data in Data Commons</p>
<CardContent>
<FormControl className={classes.formControl} fullWidth
variant="outlined" /* if the variant is omitted here, the label of the select field is misaligned */>
<InputLabel id="variable-select-label">Variable</InputLabel>
<InputLabel id="location-type-select-label">Location Type</InputLabel>
<Select
labelId="variable-select-label"
id="variable-select-id"
labelId="location-type-select-label"
id="location-type-select-id"
value={variable}
onChange={handleChangeVariableSelect}
variant="outlined"
className={classes.select}
label="Variable">
label="Location Type">
{Object.keys(phsIndexVariables).map((varKey) =>
<MenuItem key={varKey} value={varKey}
disabled={!phsIndexVariables[varKey].enabled}>{phsIndexVariables[varKey].uiLabel}</MenuItem>
)};
</Select>
<FormHelperText>Select a variable from the list</FormHelperText>
<FormHelperText>Select a location type from the list</FormHelperText>
</FormControl>
<div className={classes.separator}/>

<FormControl className={classes.formControl} fullWidth>
<FormLabel component="legend">Variable values</FormLabel>
<FormLabel component="legend">Entering location values</FormLabel>
<RadioGroup value={valueOptionRadio} onChange={handleChangeValuesOptionRadio}>
<FormControlLabel value="optionEnter" control={<Radio color={"primary"}/>} label="Enter values by hand"/>
<FormControlLabel value="optionEnter" control={<Radio color={"primary"}/>} label="Enter location values by hand"/>
<FormControlLabel value="optionSelect" control={<Radio color={"primary"}/>}
label="Use all values from selected locations"/>
label="Use all values from selected region (US states)"/>
</RadioGroup>
</FormControl>

Expand Down Expand Up @@ -174,8 +174,8 @@ export default function Step1(props) {
renderInput={(params) => (
<TextField {...params}
error={props.showLocationsError}
helperText={"Select locations (US states)"}
variant="outlined" label="Location" placeholder=""/>
helperText={"Select region (US states)"}
variant="outlined" label="States" placeholder=""/>
)}
/>
</>
Expand Down
2 changes: 1 addition & 1 deletion phs-gdc-dashboard/src/components/content/Step2.js
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ export default function Step2(props) {
>&nbsp;&nbsp;&nbsp;</IconButton>
}
/>
<p className={"stepSubHeader"}>Select the Data Commons variables you want to retrieve values from</p>
<p className={"stepSubHeader"}>Select Data Commons variables to retrieve values from</p>
<CardContent>
<div className={classes.topics}>

Expand Down
4 changes: 2 additions & 2 deletions phs-gdc-dashboard/src/components/content/TopicsTreeSelect.js
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,8 @@ export default function TopicsTreeSelect(props) {
data={statVarsTree}
onChange={handleChange}
/>
<FormHelperText className="helper-text">Search for variables by name or browse the hierarchy. <i>(Note that
many variables may not have data. Please see <a href={STATVARS_AVAILABILITY_SHEET} target="_blank">variables-location
<FormHelperText className="helper-text">Select from the hierarchy or begin typing variable name. <i>(Many variables
may not have data. Please see <a href={STATVARS_AVAILABILITY_SHEET} target="_blank">variables-location
availability list</a>.)</i></FormHelperText>
</div>
);
Expand Down

0 comments on commit e1c6f6f

Please sign in to comment.