Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update distribution format so that the value stored is the code instead of the English value. #320

Merged
merged 1 commit into from
Mar 27, 2023

Conversation

ianwallen
Copy link
Contributor

@ianwallen ianwallen commented Mar 19, 2023

Update distribution format so that the value stored is the code instead of the English value.

Fixes issue #319

Output after this fix will be distribution format similar the following

         <gmd:distributionFormat>
            <gmd:MD_Format>
               <gmd:name>
                  <gco:CharacterString>CDED ASCII</gco:CharacterString>
               </gmd:name>
               <gmd:version>
                  <gco:CharacterString>test</gco:CharacterString>
               </gmd:version>
            </gmd:MD_Format>
         </gmd:distributionFormat>

Also, the record will validate using a record with the main language as French.

@ianwallen ianwallen added the bug Something isn't working label Mar 19, 2023
@ianwallen ianwallen added this to the 3.12.10 milestone Mar 19, 2023
@ianwallen
Copy link
Contributor Author

Todo: test what happens with old data. - is there any dataloss?

@jodygarnett
Copy link
Member

Based on discussion this is required for compatibility with FGP; however the HNAP guidance document is a bit inconclusive (indicating name is used but then only linking to english name).

We have asked @bo-lu clarify FGP intent and update the document accordingly.

@ianwallen
Copy link
Contributor Author

Based on discussion this is required for compatibility with FGP; however the HNAP guidance document is a bit inconclusive (indicating name is used but then only linking to english name).

We have asked @bo-lu clarify FGP intent and update the document accordingly.

This also applies to #314

@ianwallen
Copy link
Contributor Author

Todo: test what happens with old data. - is there any data loss?

Tested with an invalid value (GEOJson) and we can see that the value is not removed so there is no data loss. It also does not validate as expected.

image

Copy link
Contributor

@josegar74 josegar74 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change works fine. Most of the values are the same in the code and the English value, but for some they are different, for existing installations can be relevant to apply some data update for these values.

@ianwallen ianwallen merged commit 20dcf1c into metadata101:3.12.x Mar 27, 2023
josegar74 pushed a commit that referenced this pull request Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants