Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gmd:distributionFormat value seems to be incorrect. #319

Open
ianwallen opened this issue Mar 16, 2023 · 3 comments
Open

gmd:distributionFormat value seems to be incorrect. #319

ianwallen opened this issue Mar 16, 2023 · 3 comments
Labels
bug Something isn't working

Comments

@ianwallen
Copy link
Contributor

FGP shows the following which uses the code in the gco:CharacterString

<gmd:distributionFormat>
            <gmd:MD_Format>
               <gmd:name>
                  <gco:CharacterString>CDED ASCII</gco:CharacterString>
               </gmd:name>
               <gmd:version>
                  <gco:CharacterString>test</gco:CharacterString>
               </gmd:version>
            </gmd:MD_Format>
         </gmd:distributionFormat>

Our System shows the following which uses the language value in the gco:CharacterString
This is incorrect because if this is what is supposed to be there then we would also require the translated text and it does not have the translated text

<gmd:distributionFormat>
            <gmd:MD_Format>
               <gmd:name>
                  <gco:CharacterString>ASCII (CDED)</gco:CharacterString>
               </gmd:name>
               <gmd:version>
                  <gco:CharacterString>test</gco:CharacterString>
               </gmd:version>
            </gmd:MD_Format>
         </gmd:distributionFormat>

So there bug seems to be related to the editor/validator that should be using codes to follow FGP
Or both English and French values should exists.

@ianwallen ianwallen added the bug Something isn't working label Mar 16, 2023
@ianwallen
Copy link
Contributor Author

Another issue with current setup is that gco:CharacterString is set based on the main language. But the value set is based on English.

  • create metadata record where the main language is French
  • Set distribution format to "ASCII (CDED)"
  • Validate to ensure it is correct. - It will fail validation with

image

This is because it tries to compare the french value to the english value.

It is better if is use codes instead to be consistent

@ianwallen
Copy link
Contributor Author

According to https://github.com/metadata101/schemas/blob/de-geogratis/hnap/2.3.1/HNAP.md#clause-51131-name
It says that the values need to be
https://www.gcpedia.gc.ca/wiki/Federal_Geospatial_Platform/Policies_and_Standards/Catalogue/Release/Appendix_B_Guidelines_and_Best_Practices/Guide_to_Harmonized_ISO_19115:2003_NAP/Format?setlang=en&uselang=en
But these are all the English values within the src/main/config/codelist/local/thesauri/theme/GC_Resource_Formats.rdf
Switching to the French does not change the codes. This seems like a bug in the documentation as it does not make sense to use English values - codes exists and are language independent.

FGP Excel Spreadsheet seems to have the correct codes as the following.
image

@bo-lu
Copy link
Member

bo-lu commented Apr 5, 2023

Hi Ian, I think it is best to keep the code value since it would require quite a bit of change for us. The application can convert these code to the bilingual value. Also, there is no clear direction from the policy side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants