Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with inserting online resource format #314

Open
ianwallen opened this issue Mar 10, 2023 · 4 comments
Open

Issue with inserting online resource format #314

ianwallen opened this issue Mar 10, 2023 · 4 comments
Milestone

Comments

@ianwallen
Copy link
Contributor

There is a bug when attempting to add an online resource format such as ASCII (CDED)

image

When validating, it produces the following error.
image

The reason, we get this error is because the data is store as

image

The validation is validating based on the real code which is CDED ASCII and it identifies that it is not the same as ASCII (CDED) and fails.

There was an attempt to fix this but with PR #259. However this PR was checking against the English code/French Code - when it should be checking the main code.

The problem is that the main code is not in the data

1 - Is there a bug in saving the data - i.e should it have the main code stored instead of translated values? This does not seem correct as it would be difficult to program to check all codes.
2 - Should the validation accept Eng code, Fra codes, and main codes in the check?

@ianwallen
Copy link
Contributor Author

@CarHenkel Can you test your environment with using values like ASCII (CDED) which has different values for Eng code (ASCII (CDED)), Fra code (ASCII (MNEC)) and main code CDED ASCII

With the change reverted, the validation should fail on that item.

@ianwallen ianwallen added this to the 3.12.10 milestone Mar 20, 2023
@ianwallen
Copy link
Contributor Author

It seems like there are 2 options.
1 Use bilingual values for the format – in which case the PR #259 can be re-applied and then we need to update the xslt for importing FGP data so that it update the codes to bilingual values.
2 Update the picker so that it stores the code instead of the translation values. This seems to be related to #95

Not sure what the best approach is for this?

@CarHenkel
Copy link

CarHenkel commented Mar 20, 2023

@CarHenkel Can you test your environment with using values like ASCII (CDED) which has different values for Eng code (ASCII (CDED)), Fra code (ASCII (MNEC)) and main code CDED ASCII

With the change reverted, the validation should fail on that item.

Hi @ianwallen

In ECCC environment:
ASCII (CDED) - Passes Validation
ASCII GRID - Passes Validation
ASCII (MNEC) - Passes Validation EN/FR Dropdown list item in fr is 'ASCII (CDED)'. Once selected, it renders as 'ASCII (MNEC)' in fr UI outside of the Create an Online Resource dialog.
CDED ASCII - Not an available option

@jodygarnett
Copy link
Member

@bo-lu can you check if the code is being stored by FGP (discussion here indicates that storing the multi-lingual label would be appropriate)

@josegar74 josegar74 modified the milestones: 3.12.11, 3.12.12 Oct 4, 2023
@josegar74 josegar74 modified the milestones: 3.12.12, 3.12.13 Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants