WIP: Add support for querying playlists #10
Conversation
|
Documentation now added, ran |
pylistenbrainz/playlist.py
Outdated
| if self.added_at: | ||
| ext['added_at'] = self.added_at.isoformat() | ||
| _maybe_add(ext, 'added_by', self.added_by) | ||
| _maybe_add(ext, 'artist_identifier', self.artist_identifiers) |
There was a problem hiding this comment.
In LB-1058 we noticed some inconsistencies in our specification of this field and decided to standardise on artist_identifiers
There was a problem hiding this comment.
Thanks for the comment! Have updated the field name in the local API, and the code will handle both options from the remote API for now.
Fixes metabrainz#9 Still to do: * Add tests for new functions and ensure coverage is OK
ssssam
force-pushed
the
sam/playlists
branch
from
6ae6463
to
4fb06fc
Compare
|
Updates:
Tests still to do, I'm happy to work on that but would appreciate some guidance from @paramsingh first so I don't spend time writing tests for an implementation that might need big changes first :-) |
|
This is stale for almost two years now, whats the status? @ssssam Do you still plan to work on this? Is it even still relevant? |
|
It worked as of 2 years ago, and has no unit tests. I don't have any immediate plans to do further work on it myself. I imagine its still relevant for anyone who wants to write tooling that works with playlists on Listenbrainz, unless there's another way to access those programmatically these days? |
Fixes #9
Still to do: