Skip staging db and aws on missing credentials #243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rugeli
changed the title
Packing analysis reportAnalysis for packing results located at cellpack/tests/outputs/test_spheres/spheresSST
Packing imageDistance analysisExpected minimum distance: 50.00
|
meganrm
approved these changes
Apr 20, 2024
mogres
approved these changes
May 2, 2024
cellpack/bin/upload.py
Outdated
| from cellpack.autopack.FirebaseHandler import FirebaseHandler | ||
| from cellpack.autopack.DBRecipeHandler import DBUploader | ||
|
|
||
| from cellpack.autopack.interface_objects.database_ids import DATABASE_IDS | ||
| from cellpack.autopack.loaders.recipe_loader import RecipeLoader | ||
|
|
||
| ############################################################################### | ||
| log_file_path = Path(__file__).parent.parent / "logging.conf" |
There was a problem hiding this comment.
Are we using the logger anywhere in this file?
There was a problem hiding this comment.
Thank you for catching that! I ended up using sys instead of log and forgot to clean up the logger setup, will remove it now
| * Create a Firebase project in test mode with your google account, select `firebase_admin` as the SDK. [Firebase Firestore tutorial](https://firebase.google.com/docs/firestore) | ||
| * Generate a new private key by navigating to "Project settings">"Service account" in the project's dashboard. | ||
| * For dev database: | ||
| * Create a Firebase project in test mode with your google account, select `firebase_admin` as the SDK. [Firebase Firestore tutorial](https://firebase.google.com/docs/firestore) |
mogres
reviewed
May 3, 2024
cellpack/autopack/__init__.py
Outdated
| @@ -387,6 +387,10 @@ def load_file(filename, destination="", cache="geometries", force=None): | |||
| if database_name == "firebase": | |||
| db = DATABASE_IDS.handlers().get(database_name) | |||
| initialize_db = db() | |||
| if not initialize_db._initialized: | |||
| sys.exit( | |||
| "The selected database is not initialized. Please set up Firebase credentials to pack remote recipes." | |||
There was a problem hiding this comment.
Could link to the readme/instructions here similar to how we do for missing AWS credentials
mogres
reviewed
May 3, 2024
cellpack/bin/upload.py
Outdated
| recipe_db_handler.upload_recipe(recipe_meta_data, recipe_full_data) | ||
| else: | ||
| sys.exit( | ||
| "The selected database is not initialized. Please set up Firebase credentials to upload recipes." |
There was a problem hiding this comment.
Could link to the readme/instructions here similar to AWS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
What is the problem this work solves, including
closes #238
Solution
To address the issue of missing aws or firebase credentials when running local packings, the following changes were made:
- skipped the saving process for staging database and aws s3 bucket
- disabled the automatic opening of new browser tabs related to aws urls
- updated documentation
Type of change
Please delete options that are not relevant.
Steps to Verify: