remove pandas3d #226
Merged
remove pandas3d #226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Packing analysis reportAnalysis for packing results located at cellpack/tests/outputs/test_spheres/spheresSST
Packing imageDistance analysisExpected minimum distance: 50.00
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #226 +/- ##
=======================================
Coverage 98.63% 98.63%
=======================================
Files 18 18
Lines 511 511
=======================================
Hits 504 504
Misses 7 7 ☔ View full report in Codecov by Sentry. |
|
Looks good to me! Here are my observations:
|
mogres
approved these changes
Feb 3, 2024
| @@ -94,16 +94,14 @@ Display packing in realtime (slow) | |||
|
|
|||
| ### place_method | |||
|
|
|||
| _Optional `enum`_. One of `"jitter"`, `"spheresSST"`, `"pandaBullet"`.. Default: `"jitter"`. | |||
| _Optional `enum`_. One of `"jitter"`, `"spheresSST"`.. Default: `"jitter"`. | |||
There was a problem hiding this comment.
Is the current default spheresSST?
| @@ -2701,324 +2648,26 @@ def setupOctree( | |||
| self.grid.getRadius(), helper=helper | |||
| ) # Octree((0,0,0),self.grid.getRadius()) #0,0,0 or center of grid? | |||
|
|
|||
There was a problem hiding this comment.
This function used to take so long to run! Good to have it removed
rugeli
approved these changes
Feb 3, 2024
|
We can merge this one if ready, @meganrm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
pandas3d slow to install and we're not currently using it. Closes #219
Solution
removed it
Type of change
Steps to Verify: