Feature/upload to s3 #181
Closed
Feature/upload to s3 #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…m/mesoscope/cellpack into feature/upload-to-s3
…m/mesoscope/cellpack into feature/upload-to-s3
…ellpack into feature/upload-to-s3
…ellpack into feature/upload-to-s3
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## main #181 +/- ##
==========================================
+ Coverage 98.39% 98.52% +0.13%
==========================================
Files 14 15 +1
Lines 435 475 +40
==========================================
+ Hits 428 468 +40
Misses 7 7
☔ View full report in Codecov by Sentry. |
Packing analysis reportAnalysis for packing results located at cellpack/tests/outputs/test_spheres/spheresSST
Packing imageDistance analysisExpected minimum distance: 50.00
|
meganrm
reviewed
Aug 2, 2023
| def __init__(self, db_handler): | ||
| self.db = db_handler | ||
| if isinstance(db_handler, FirebaseHandler): | ||
| DBHandler.firebase_handler = db_handler |
There was a problem hiding this comment.
this shouldn't be in this file. The idea of DBHandler is it's agnostic to what handler is being used. There should be nothing explicitly referencing firebase in this file
meganrm
reviewed
Aug 2, 2023
meganrm
changed the base branch from
main
to
feature/firebase-upload-gradients
meganrm
changed the base branch from
main
to
feature/run-recipes-from-firebase
rugeli
force-pushed
the
feature/upload-to-s3
branch
from
14042b5
to
f6533c9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
What is the problem this work solves, including
closing #140
Solution
What I/we did to solve this problem
simularium_helper.py, added functionalities to store results to S3 -cellpack-results/simularium, upload metadata to firebase, and open packing results in simularium app.with @meganrm @mogres
Type of change
Please delete options that are not relevant.
Steps to Verify:
pack -r [path-to-a-local-recipe] -c [path-to-a-config-file]firebase:recipes/[firebase-recipe-id] -c [path-to-a-config-file](make sure you have the recipe living in your firebase before packing)Keyfiles (delete if not relevant):
1.
simularium_helper.py2.
AWSHandler.py