Feature/firebase upload gradients #170
Conversation
…ture/firebase-upload-gradients
…oscope/cellpack into feature/firebase-upload-gradients
Packing analysis reportAnalysis for packing results located at cellpack/tests/outputs/test_spheres/spheresSST
Packing imageDistance analysisExpected minimum distance: 50.00
|
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## main #170 +/- ##
==========================================
+ Coverage 98.42% 98.52% +0.10%
==========================================
Files 15 16 +1
Lines 444 476 +32
==========================================
+ Hits 437 469 +32
Misses 7 7
☔ View full report in Codecov by Sentry. |
…m/mesoscope/cellpack into feature/run-recipes-from-firebase
|
@rugeli could you pull from main whenever you get a chance so that updates from your other branch get merged in? |
| for item in CompositionDoc.SHALLOW_MATCH: | ||
| if db_data[item] != local_data[item]: | ||
| print(db_data[item], local_data[item]) | ||
| shallow_match = False | ||
| break |
There was a problem hiding this comment.
This break statement should probably be a return statement? It looks like it only breaks out of the inner loop right now.
| break | |
| return None, None |
There was a problem hiding this comment.
yeah I know it's confusing, the readability of this function is truly a concern for us. Let's address it during our group programming session this week.
cellpack/tests/test_gradient_doc.py
Outdated
There was a problem hiding this comment.
These are great, thanks for adding tests!
fix print statement Co-authored-by: Saurabh Mogre <[email protected]>
Co-authored-by: Saurabh Mogre <[email protected]>
Feature/resovle grads in comp
…ture/firebase-upload-gradients
…ture/firebase-upload-gradients
Problem
What is the problem this work solves, including
completes gradient collection upload in #124
closes #129
Solution
What I/we did to solve this problem
GradientDocclass to handle gradient data uploads if it is included in the recipe we are uploading to firebaseExpected Behavior
gradientscollectionType of change
Change summary:
peroxisomes_surface_gradient.jsonandgradients.jsonSteps to Verify:
conda activate autopackupload -r [relative-path-to-a-gradient-recipe] -c [your-firebase-cred-path]pytest cellpackScreenshots (optional):