Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider removing panda3d dependency? #219

Closed
mogres opened this issue Jan 13, 2024 · 0 comments · Fixed by #226
Closed

Consider removing panda3d dependency? #219

mogres opened this issue Jan 13, 2024 · 0 comments · Fixed by #226

Comments

@mogres
Copy link
Collaborator

mogres commented Jan 13, 2024

Use Case

Our current default packing method spheresSST does not require panda3d which adds extra overhead and error messages during import.

Running a test recipe after disabling panda3d (by commenting out lines of code where it was used) resulted in a speedup of ~30%. This can be significant when generating a large number of packings.

Solution

Remove functions and imports that rely on panda3d. Currently, there is some code that uses it for real time display which is no longer an available feature.

Alternatives

Only remove panda3d from the spheresSST workflow while still keeping it in other places if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant