Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add functionality to connect to serial via NodeJS #98

Conversation

TheCyberRonin
Copy link
Contributor

@TheCyberRonin TheCyberRonin commented Aug 22, 2024

This PR will:

  • Add NodeSerialConnection and nodeTransformHandler
    • These work in tandem to connect to a device via serial using NodeJS
    • serialport was added as a dependency for this as well
  • Add example JS file to show it being used

I can send and receive packets and data using this code. There is a lot to test out and I'm hoping people can use this to poke holes. This shouldn't have an impact on any of the other connection types.

This should do the trick for #86
solves #83

@CLAassistant
Copy link

CLAassistant commented Aug 22, 2024

CLA assistant check
All committers have signed the CLA.

@TheCyberRonin
Copy link
Contributor Author

I'll fix up that space on a newline so the linter is happy tonight

@sachaw
Copy link
Member

sachaw commented Aug 22, 2024

Thanks for the PR.
I eventually want to publish a single cross-platform fore package and additional transport adapter's but this can definitely happen after merging this.
Let me know when you're ready to merge.

@TheCyberRonin
Copy link
Contributor Author

Thanks for the PR. I eventually want to publish a single cross-platform fore package and additional transport adapter's but this can definitely happen after merging this. Let me know when you're ready to merge.

Are there any GitHub Projects or future plans that I could help tackle? During this work, I noticed that there are packets being ignored that seem to have Bluetooth start sequences. I was planning on tackling some of the packet types that aren't yet being parsed.

I think after that version bump, I appeased the GitHub Actions gods. As long as everyone is ok with this change, I think it's good to merge. If any issues arise with this code, I'll gladly work on improving it and bugfix.

@Hunter275
Copy link
Member

@sachaw just waiting on your review and I think this can be merged. I can also merge it if you want.

@Hunter275 Hunter275 changed the base branch from master to protobufs-and-serialconsole August 24, 2024 03:10
@Hunter275 Hunter275 merged commit f45d65a into meshtastic:protobufs-and-serialconsole Aug 24, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants