Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Fixed the modal screen fit issue w/signoff #1805

Closed
wants to merge 0 commits into from

Conversation

kanishk6103
Copy link
Contributor

Description

This PR fixes #1803

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

Copy link

welcome bot commented Jul 5, 2024

Yay, your first pull request! 👍 A contributor will be by to give feedback soon. In the meantime, please review the Newcomers' Guide and sure to join the community Slack.
Be sure to double-check that you have signed your commits. Here are instructions for making signing an implicit activity while peforming a commit.

Copy link

netlify bot commented Jul 5, 2024

Deploy Preview for mesheryio-preview ready!

Name Link
🔨 Latest commit 3d4b0f0
🔍 Latest deploy log https://app.netlify.com/sites/mesheryio-preview/deploys/66ba744f2c5bdc00086732ca
😎 Deploy Preview https://deploy-preview-1805--mesheryio-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Gemfile.lock Outdated Show resolved Hide resolved
Copy link

@Ashparshp Ashparshp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test for mobile screens as I can see it's not working perfectly fine!

@kanishk6103
Copy link
Contributor Author

Test for mobile screens as I can see it's not working perfectly fine!

I checked for mobile screens, height wise they work fine but width wise they're cut-off, is that the issue you are talking about? @Ashparshp

@Ashparshp
Copy link

When you scroll it check for buttons they don't fit!

@kanishk6103
Copy link
Contributor Author

kanishk6103 commented Jul 7, 2024

When you scroll it check for buttons they don't fit!

image

Does this look fine? @Ashparshp

@vishalvivekm
Copy link
Member

@kanishk6103
Thank you for your contribution.
Let's discuss this on Websites' call. Adding this as an agenda item into the meeting minutes.

@kanishk6103
Copy link
Contributor Author

@kanishk6103 Thank you for your contribution. Let's discuss this on Websites' call. Adding this as an agenda item into the meeting minutes.

sure

Copy link

@Ashparshp Ashparshp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! But why are you creating so many commits? It seems like there are a lot of empty ones.

@kanishk6103
Copy link
Contributor Author

LGTM! But why are you creating so many commits? It seems like there are a lot of empty ones.

I am really sorry for that, when I commited the responsive behaviour of buttons I forgot to sign it, so I had to rebase which made a lot of commits. Other than that, the master branch was being updated so I was updating my branch which again created a bit more commits. I am sorry for that.

@Ashparshp
Copy link

@kanishk6103, you've created 20 commits?

@kanishk6103
Copy link
Contributor Author

@kanishk6103, you've created 20 commits?

I did not mean to create them, as I said I forgot to sign, so I had to rebase and sign the previous ones, that created commits, rest are me updating my branch to the latest ones. Again, I am sorry for this, what should I do? @Ashparshp

@Ashparshp
Copy link

@kanishk6103, no worries at all! These things happen.... I was just reminding you in case you missed it. You can also ignore this for now... No sweat 😅. Keep up the good work!

@Ashparshp
Copy link

Also, If you want to clean up the commit history, you can squash your commits into one. This will help keep the history neat...

@sudhanshutech
Copy link
Member

@kanishk6103 ?

@kanishk6103
Copy link
Contributor Author

kanishk6103 commented Aug 8, 2024

@kanishk6103 ?

Hey! I think i should raise a new PR, this one is a bit messed up.

@sudhanshutech

@kanishk6103
Copy link
Contributor Author

kanishk6103 commented Aug 12, 2024

I have created a new PR for this: #1859
@Ashparshp

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Catalog] Modals on Meshery Catalog are not fitting to the screen
5 participants