Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Made video controls visible #1801

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Muhammed-Moinuddin
Copy link
Contributor

Description
Made Pop-up responsive so now video controls are visible.

This PR fixes #1776

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

Signed-off-by: Muhammad Moinuddin <[email protected]>
Copy link

netlify bot commented Jul 4, 2024

Deploy Preview for mesheryio-preview ready!

Name Link
🔨 Latest commit c81c1cb
🔍 Latest deploy log https://app.netlify.com/sites/mesheryio-preview/deploys/66d23682e8724c00080f942e
😎 Deploy Preview https://deploy-preview-1801--mesheryio-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@vishalvivekm
Copy link
Member

Thank you for your contribution.
Let's discuss this on Websites' call. Adding this as an agenda item into the meeting minutes.

@Muhammed-Moinuddin
Copy link
Contributor Author

Thank you for your contribution. Let's discuss this on Websites' call. Adding this as an agenda item into the meeting minutes.

Sure.

margin: 25% auto;
width: 85%; /* Change width to 85% */
};
@media (min-width: 481px) and (max-width: 768px) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why use of lot of media queries?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To make it visible in most of the screens.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this issue valid with you?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this much of use of media quries doesn't sound reasonable. Its hard to maintain . These media quries is always hard to manually maintain. There is other css alternative also

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noted

@sudhanshutech
Copy link
Member

@Muhammed-Moinuddin add this agenda for website meeting . Lets discuss and finalize this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pop-up does not show video controls on large screens
3 participants