Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Catalog] Modals on Meshery Catalog are not fitting to the screen #1803

Open
Ashparshp opened this issue Jul 4, 2024 · 8 comments · May be fixed by #1859
Open

[Catalog] Modals on Meshery Catalog are not fitting to the screen #1803

Ashparshp opened this issue Jul 4, 2024 · 8 comments · May be fixed by #1859
Assignees
Labels
area/catalog help wanted Extra attention is needed issue/willfix This issue will be worked on

Comments

@Ashparshp
Copy link

Ashparshp commented Jul 4, 2024

Add or update the following Meshery Catalog item(s):

Name: Modal Screen Fit Issue
Type: UI Bug
Compatibility: All Browsers
Pattern ID: N/A
image:
Screenshot
Pattern Info: Modals on the Meshery Catalog are not fitting to the screen. They are exceeding the screen boundaries, making the content not completely visible.
Pattern Caveats: N/A
URL: Meshery Catalog
Download link:

Steps to Reproduce:

  1. Go to Meshery Catalog.
  2. Click on any item to open a modal.
  3. Observe that the modal content exceeds the screen boundaries and is not fully visible.

Expected Behavior:
The modals should be fully visible and fit within the screen boundaries, ensuring that all content is accessible and readable.

Environment:

  • Browser: Chrome
  • Operating System: Windows

Contributor Resources

The meshery.io website uses Jekyll and GitHub Pages. Site content is found under the master branch.

Copy link

welcome bot commented Jul 4, 2024

Thanks for opening this issue. A contributor will be by to give feedback soon. In the meantime, please review the Newcomers' Guide and sure to join the community Slack.

@Ashparshp Ashparshp added the help wanted Extra attention is needed label Jul 4, 2024
@kanishk6103
Copy link
Contributor

I wish to contribute to this

@akshansh-modi
Copy link
Contributor

Hey @kanishk6103 and @Ashparshp,

I'm keen on fixing the modal screen fit issue in the Meshery Catalog. From my review, changing model-window > div { height: auto; } to model-window > div { height: 90%; } in the SCSS should make the modals fit within screen boundaries.

Could you please assign this issue to me? I'm ready to dive in and get it sorted!

Thanks!

@Ashparshp
Copy link
Author

Thanks for your interest, @kanishk6103 and @akshansh-modi!

@kanishk6103, since you expressed interest first and to maintain chronological order, the issue is assigned to you.

@akshansh-modi, thank you for your willingness to help. If @kanishk6103 needs assistance, we'll reach out to you next.

@kanishk6103
Copy link
Contributor

Hey can you please review my PR? @Ashparshp

Copy link

stale bot commented Aug 9, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the issue/stale Issue has not had any activity for an extended period of time label Aug 9, 2024
@Ashparshp Ashparshp added the issue/willfix This issue will be worked on label Aug 9, 2024
@stale stale bot removed the issue/stale Issue has not had any activity for an extended period of time label Aug 9, 2024
@Ashparshp
Copy link
Author

Ashparshp commented Aug 9, 2024

@kanishk6103 Any update?

@akshansh-modi
Copy link
Contributor

akshansh-modi commented Aug 10, 2024

@Ashparshp hey if this issue still require help , can i work on it ?

@kanishk6103 kanishk6103 linked a pull request Aug 12, 2024 that will close this issue
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/catalog help wanted Extra attention is needed issue/willfix This issue will be worked on
Projects
None yet
3 participants