Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pop-up does not show video controls on large screens #1776

Open
Muhammed-Moinuddin opened this issue Jun 25, 2024 · 7 comments · May be fixed by #1801
Open

Pop-up does not show video controls on large screens #1776

Muhammed-Moinuddin opened this issue Jun 25, 2024 · 7 comments · May be fixed by #1801
Labels
issue/willfix This issue will be worked on kind/bug Something isn't working

Comments

@Muhammed-Moinuddin
Copy link
Contributor

Description

On page https://meshery.io/catalog , after clicking import any catalog item link there is a pop-up containing video tutorial. So on large screen the video controls are not visible.

Expected Behavior

The pop-up needs to be responsive on large screens, so it shows video controls.

Screenshots

On large screens
ss1

On normal screens
ss2

I would like to work on it.

Enviroment:

  • OS: Mac Linux Windows
  • Browser: Chrome Safari Firefox
  • Version:
  • Device: Desktop Mobile

Contributor Guides and Handbook

The meshery.io website uses Jekyll and GitHub Pages. Site content is found under the master branch.

@Muhammed-Moinuddin Muhammed-Moinuddin added the kind/bug Something isn't working label Jun 25, 2024
@leecalcote
Copy link
Member

Users are unable to scroll down the page to see the controls, is that right, @Muhammed-Moinuddin?

@kanishk6103
Copy link
Contributor

I can try solving this issue @leecalcote @Muhammed-Moinuddin

@Muhammed-Moinuddin
Copy link
Contributor Author

Users are unable to scroll down the page to see the controls, is that right, @Muhammed-Moinuddin?

You would have been right if pop-up were a part of the screen. But it's not like that, screen is separate from pop-up and is scrollable so we just need to make pop-up a bit responsive for the large screens.

@Muhammed-Moinuddin Muhammed-Moinuddin linked a pull request Jul 4, 2024 that will close this issue
1 task
@Ashparshp
Copy link

Perfect.webm

Thank you for your work on this issue. However, after reviewing your fix, I found that the original functionality was perfectly fine, and the video controls were visible as intended. Therefore, I don't believe this is a valid issue. Could you please double-check from your side?

@Ashparshp
Copy link

@Muhammed-Moinuddin Also, in the future, could you please wait for assignment or confirmation before starting work on an issue?

@Muhammed-Moinuddin
Copy link
Contributor Author

Perfect.webm
Thank you for your work on this issue. However, after reviewing your fix, I found that the original functionality was perfectly fine, and the video controls were visible as intended. Therefore, I don't believe this is a valid issue. Could you please double-check from your side?

It is valid issue, the browser makes it like scrollable but it is not and video controls are hiding due to it. We'll discuss this in upcoming meeting.

Copy link

stale bot commented Aug 9, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the issue/stale Issue has not had any activity for an extended period of time label Aug 9, 2024
@Ashparshp Ashparshp added the issue/willfix This issue will be worked on label Aug 9, 2024
@stale stale bot removed the issue/stale Issue has not had any activity for an extended period of time label Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue/willfix This issue will be worked on kind/bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants