update news and cran-comments with issue resolution #74 and #75

merliseclyde · Dec 6, 2023 · daf340e · daf340e
1 parent 580bf3e
commit daf340e
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 3 deletions.
diff --git a/NEWS.md b/NEWS.md
@@ -1,5 +1,10 @@
 # BAS (development version)
 
+* addressed problem identified by `valgrind` with uninitialized variable
+in `hyp1f1.c`  (issue #75)
+
+* removed models that have zero prior probability in `bas.lm` and `bas.glm` (issue #74)
+
 # BAS 1.7.0
 
 ## Minor Improvements and Fixes

diff --git a/cran-comments.md b/cran-comments.md
@@ -1,20 +1,25 @@
-# BAS 1.7.0 Comments to CRAN
+# BAS 1.7.1 Comments to CRAN
 
 # Notes to CRAN
 
-## Submission reason 
+## ReSubmission reason 
 
 Submission prior to Dec 14 required to maintain package on CRAN.
 Status  on CRAN check page  under `Additional Issues` for `valgrind`  showed warnings  `Conditional jump or move depends on uninitialised value(s)`.  
 
 - Initialized vector `se`  via `memset` and `disp = 1.0` in  `fit_glm.c` (issue #72)
 
-- Fixed issue #67 reported on Github and added unit test
+- Initialized variables in `hyp1f1.c` from `testthat` (issue #75) 
+
+- Removed models that have zero prior probability in `bas.lm` and `bas.glm` (issue #74)
+
+- Fixed error in `bayesglm.fit` to check arguments `x` or `y` for correct type before calling C  and added unit test (issue #67) 
 
 
 ## Test environments
 
 - r-devel with valgrind via docker
+- r-devel with valgrind via rhub github actions
 - mac-builder r-release  macosx-arm64 
 - local OS X install, R 4.3.2 (x86)
 - ubuntu  (github actions CI), R-release R-devel R-oldrelease