Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update NPM package to use Ag Grid 31.1.0 #55

Merged
merged 1 commit into from
Mar 7, 2024

Conversation

maxhille
Copy link
Contributor

@maxhille maxhille commented Feb 26, 2024

This change updates the NPM package to use AG Grid 31.1.x

Notable proposed changes:

  • The custom element wrapper code got simplified due to simplification in AG Grid's API
  • AG Grid changed how internal modules are set up and also integrated big new features (like embedded charts) we we do not yet support. So it makes sense to no longer include the packaged versions but the modules to we can only import the needed parts.
  • Since users upgrading to this package version have to change their embedding code, the version bump is major.

Also Closes #3

@Tranquility
Copy link
Contributor

Ag-grid added data type inferring https://www.ag-grid.com/javascript-data-grid/cell-data-types/ this could simplify a few things in the future. But I wonder if we need to disable it for now to make sure that our formatting code still works.

@maxhille
Copy link
Contributor Author

Ag-grid added data type inferring https://www.ag-grid.com/javascript-data-grid/cell-data-types/ this could simplify a few things in the future. But I wonder if we need to disable it for now to make sure that our formatting code still works.

Are you sure this is new (after v29)?

@Tranquility
Copy link
Contributor

Ag-grid added data type inferring https://www.ag-grid.com/javascript-data-grid/cell-data-types/ this could simplify a few things in the future. But I wonder if we need to disable it for now to make sure that our formatting code still works.

Are you sure this is new (after v29)?

https://blog.ag-grid.com/whats-new-in-ag-grid-30/

NPM_CHANGELOG.md Outdated Show resolved Hide resolved
@maxhille maxhille force-pushed the ag-grid-v31 branch 2 times, most recently from 669588d to 6b982c4 Compare March 6, 2024 12:47
@mschindlerMM mschindlerMM merged commit be38471 into mercurymedia:main Mar 7, 2024
1 check passed
@maxhille maxhille deleted the ag-grid-v31 branch March 11, 2024 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using the library with individual ag grid packages
3 participants