Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: handle if error.originalError.errors is not array #1095

Merged
merged 2 commits into from
Apr 22, 2024
Merged

fix: handle if error.originalError.errors is not array #1095

merged 2 commits into from
Apr 22, 2024

Conversation

dancastillo
Copy link
Contributor

fixes #1024

  • Current unit test handle coverage so no test was added
  • Fix: Check that error.orginialError.errors is an Array

@jonnydgreen
Copy link
Contributor

Thanks for submitting! Could you add a test for this please? :)

@dancastillo
Copy link
Contributor Author

@jonnydgreen tests should be added in now

mcollina
mcollina approved these changes Apr 4, 2024
View reviewed changes
Copy link
Collaborator

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit 04d9bc3 into mercurius-js:master Apr 22, 2024
10 checks passed
@snyk-io snyk-io bot mentioned this pull request Jul 16, 2024
Open
@WontonSam WontonSam mentioned this pull request Jul 17, 2024
Open
@WontonSam WontonSam mentioned this pull request Aug 8, 2024
Open
@WontonSam WontonSam mentioned this pull request Sep 30, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Occasional "error.originalError.errors.map is not a function" errors
3 participants
@dancastillo @jonnydgreen @mcollina