Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(persistedQueries): moving the executor out of routes.js #1078

Closed

Conversation

barelyhuman
Copy link
Contributor

Refactor required to make it easier for external tooling to also be able to reuse the persistedQuery logic

Closes: nearform/mercurius-dynamic-schema#4

Refactor required to make it easier for external tooling to also be
able to reuse the persistedQuery logic
Copy link
Collaborator

@simoneb simoneb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please undo all formatting changes? The functional changes are invisible because of them.

@barelyhuman
Copy link
Contributor Author

Can you please undo all formatting changes? The functional changes are invisible because of them.

Will revert, but there's no functional changes, just moved the executePersistedQuery out of routes.js, Line number 235 is all that has changed

@barelyhuman
Copy link
Contributor Author

Closing in lieu of #1080

@barelyhuman barelyhuman closed this Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support persisted queries
2 participants