Improve Acurite-606TX decoder to also decode the Technoline TX960 sensor #3078
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Very nice, thanks! Can you run |
Done. (This changed a few lines unrelated to this PR (protocol 266), which I didn't include in the commit. Do you want me to add all changes caused by this?) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3074, see that issue for background.
In short: The Technoline TX960 is almost identical to the existing Acurite 606TX temperature sensor. The only difference seems to be the final bit of each message, which is zero for Acurite but is the negated battery bit for the Technoline sensor.
By removing a sanity check on this last bit, both sensors get decoded reliably.