-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Arad Master Meter water utility meter decoder #2984
Conversation
For decoding Arad Dialog 3G water meter
Only when the checksum is found and working well :) I'll take a peek at the posted codes. |
The presumed checksum is only one byte as seen in this BitBench. edit: I assumed wrong. the length indicators were just short… |
Is it possible to record codes from the same serial over a longer time? Ideally we would get codes with only the count field slowly increasing. Then we could infer what kind of checksum is used. |
Since the resolution of the water meter is only 100 litter it changes very slow. 000000003e690aec7ac84bdab18c73006a0e000005aac3d942d8fc 000000003e690aec7ac84bfa1c907300ba060000059e9a639380fc 000000003e690aec7ac84b3320940000de0e00000518adbb8048fe I will try to record some more. |
It is my first pull request, so please tell me if I need to de anything other then I did. |
Thanks! Basically looks good. I don't think we are going to find the checksum/digest/MAC anytime soon, so this can go in as-is. There are some code style issues to fix. Use 4 spaces to indent (e.g. clang-format / data_make doesn't look right). Also remove all trailing spaces (as the checker mentions). The addition of "Credits to all users of mentioned forum below!" is unusual but ok. It should be stand-alone though. E.g. "Additional credits to participants of THE-THREAD" |
Second round of check rejects clean up
Sorry for not reading thoroughly the contribute.md. |
Am I done here, or there is some more to do? |
This decoder decodes the Arad/Master Meter Dialog3G water utility meter.
Decoder returns meter's Serial number and water reading.
Large portion of the payload still to be decoded.
Test results:
Running the decoder yields for example:
I am not sure why the decoder is disabled by default and should I change it?