Add support for ThermoPro TP829b and Improve rtl_433_mqtt_hass.py #2964
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/devices/thermopro_tp829b.c
Outdated
| bitbuffer_extract_bytes(bitbuffer, 0, offset, b, 9 * 8); | ||
|
|
||
| // checksum is a Galois bit reflect and byte reflect | ||
| // need first to reverse byte order then the galois bit reflect. |
There was a problem hiding this comment.
Note that galois is a type of LFSR and bit/byte reflect is just input ordering.
There was a problem hiding this comment.
Yes, I did the finding with revdgst but I'm not able to find the corresponding function at rtl_433, I explored bit_util.c.
- I found lfsr_digest8() where the bit are reflect (bit from 8 to 1), but in normal byte order in the array.
- I found lfsr_digest8_reflect() where the bytes are reflect from last to first byte but bit are from bit 1 to bit 8.
- So missing a function to have both byte reflect and bit reflect, the reason why I need to reverse the order of byte first, then lfsr_digest8() as a workaround.
src/devices/thermopro_tp829b.c
Outdated
| decoder_log_bitrow(decoder, 2, __func__, b, 72, "MSG"); | ||
|
|
||
| uint16_t id = b[0] << 8 | b[1]; | ||
| float p1_temp = ((b[2] << 4 | (b[3] & 0xF0) >> 4) - 500) * 0.1f; |
There was a problem hiding this comment.
It could be better to have
int p1_raw = ...;
float p1_temp = (p1_raw - 500) * 0.1f;
and then DATA_COND on the int (avoid != on float)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #2961
This decoder is decoding 4 temp probes, the reason why rtl_433_mqtt_hass.py is also updated accordingly (2 temp probes in previous version)